Commit b5e73ded authored by SeeBeyond's avatar SeeBeyond

Fix bug where out-of-bounds check reads number of tables not latest chart id to generate metadata

parent c219a3d5
...@@ -139,7 +139,7 @@ class SystemController extends AbstractController ...@@ -139,7 +139,7 @@ class SystemController extends AbstractController
$baseUrl = $request->getScheme() . '://' . $request->getHttpHost() . $request->getBasePath(); $baseUrl = $request->getScheme() . '://' . $request->getHttpHost() . $request->getBasePath();
// Calculate Max Count // Calculate Max Count
$songCount = $em->getRepository(Song::class)->createQueryBuilder('u')->select('count(u.id)')->getQuery()->getSingleScalarResult(); $songCount = $em->getRepository(Song::class)->createQueryBuilder('u')->select('MAX(id)')->getQuery()->getSingleScalarResult();
if($songID > $songCount) { if($songID > $songCount) {
return $this->redirectToRoute('moderation.system.index'); return $this->redirectToRoute('moderation.system.index');
} }
...@@ -254,7 +254,7 @@ class SystemController extends AbstractController ...@@ -254,7 +254,7 @@ class SystemController extends AbstractController
$baseUrl = $request->getScheme() . '://' . $request->getHttpHost() . $request->getBasePath(); $baseUrl = $request->getScheme() . '://' . $request->getHttpHost() . $request->getBasePath();
// Calculate Max Count // Calculate Max Count
$songCount = $em->getRepository(Song::class)->createQueryBuilder('u')->select('count(u.id)')->getQuery()->getSingleScalarResult(); $songCount = $em->getRepository(Song::class)->createQueryBuilder('u')->select('MAX(id)')->getQuery()->getSingleScalarResult();
if($songID > $songCount) { if($songID > $songCount) {
return $this->redirectToRoute('moderation.system.index'); return $this->redirectToRoute('moderation.system.index');
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment