added graceful errors for uploading

public/assets/css/upload.css

@@ -184,3 +184,19 @@
   display: flex;
   justify-content: flex-end;
 }
+.flashbang {
+  padding: 20px;
+  margin-bottom: 25px;
+  border: 2px solid #fff;
+  border-radius: 6px;
+}
+.flashbang.flashbang-success {
+  background: rgba(121, 223, 90, 0.1);
+  border-color: #79df5a;
+  color: #79df5a;
+}
+.flashbang.flashbang-error {
+  background: rgba(197, 65, 76, 0.1);
+  border-color: #c5414c;
+  color: #c5414c;
+}

public/assets/css/upload.less

@@ -157,4 +157,21 @@
         display: flex;
         justify-content: flex-end;
     }
+}
+.flashbang {
+    padding: 20px;
+    margin-bottom: 25px;
+    border: 2px solid #fff;
+    border-radius: 6px;
+
+    &.flashbang-success {
+        background: rgba(121, 223, 90, 0.1);
+        border-color: #79df5a;
+        color: #79df5a;
+    }
+    &.flashbang-error {
+        background: rgba(197, 65, 76, 0.1);
+        border-color: #c5414c;
+        color: #c5414c;
+    }
 }
\ No newline at end of file

src/Controller/UploadController.php

@@ -112,7 +112,7 @@ class UploadController extends AbstractController
                                     }
                                 }
                             } catch(Exception $e) {
-                                var_dump($e);
+                                $this->addFlash('error', 'Uploading failed. Please report back to our development team!');
 
                                 // clean up temp files
                                 $hf = new HelperFunctions();
@@ -131,7 +131,7 @@ class UploadController extends AbstractController
                                     }
                                 }
                             } catch(Exception $e) {
-                                var_dump($e);
+                                $this->addFlash('error', 'Uploading failed. Please report back to our development team!');
 
                                 // clean up temp files
                                 $hf = new HelperFunctions();
@@ -150,7 +150,7 @@ class UploadController extends AbstractController
                                     }
                                 }
                             } catch(Exception $e) {
-                                var_dump($e);
+                                $this->addFlash('error', 'Uploading failed. Please report back to our development team!');
 
                                 // clean up temp files
                                 $hf = new HelperFunctions();
@@ -186,13 +186,13 @@ class UploadController extends AbstractController
                             
                             return $this->redirectToRoute('song.detail', ['songId' => $song->getId()]);
                         } catch(\Exception $e) {
-                            throw $e;
+                            $this->addFlash('error', 'Uploading failed. Please report back to our development team!');
                         }
                     } catch(\Exception $e) {
-                        throw $e;
+                        $this->addFlash('error', 'Uploading failed. Please report back to our development team!');
                     }
                 } else {
-                    throw new \Exception("Error when extracting ZIP file");
+                    $this->addFlash('error', 'Uploading failed. Please report back to our development team!');
                 }
 
             }

templates/upload/index.html.twig

@@ -4,7 +4,15 @@
 
 {% block content %}
   <section class="section-upload">
-    {{ form_start(uploadForm) }}
+    {{ form_start(uploadForm) }} 
+      {% for label, messages in app.flashes %}
+          {% for message in messages %}
+              <div class="flashbang flashbang-{{ label }}">
+                  {{ message }}
+              </div>
+          {% endfor %}
+      {% endfor %}
+
       <div class="box">
         <div class="title">Upload</div>
         <div class="upload-input">